People is most important. Both staff & customers must make it an enjoyable place to hang out and smoke. I'll never return if either are not pleasant to be around. They should be knowledgeable for most customers, but I can overlook some lacking knowledge because I'm comfortable with cigars. I can look up info if I want specifics beyond the basics the staff can provide. So, personally their knowledge is not a deal breaker...unless it would cause problems with proper cigar storage (ie. Mold, dry cigars, or off flavors)
Smoking space & ventilation are second. I want a comfortable chair to sit in when smoking my cigar. I also don't want to choke or have my eyes sting because of a smoke filled lounge.
As long as they have a decent selection and the above two, I'll frequent it. If I want a better selection or a specific cigar, il go to a different shop, the Internet, or other BOTLs to get it. Luckily for me, there are several shops in the immediate Dallas area that I can get almost anything locally.
I guess location needs to be mentioned. If it's too far from the house, visits would obviously be less frequent. I'm not going to drive an hour when a suitable shop is only 10 minutes from my house.
BYOB is my preferred way to go on the alcohol. But a bar is nice if it's not your local shop with your preferred beverage in your locker. The bar can limit what your options for things like scotch and wine.